-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch dependency to browsergym-core #5242
base: main
Are you sure you want to change the base?
Conversation
93b54dd
to
d86250c
Compare
@openhands-agent This PR's CI jobs give the error:
Fix this. You should only run this, and commit the poetry file. Do not attempt to test and no NOT update packages. Keep it minimal. Just fix the file. |
From the logs: 01:26:25 - openhands:ERROR: resolve_issue.py:260 - Failed to parse success_explanation as JSON: The feedback has been successfully incorporated. The AI agent correctly:
This focused response directly addresses the CI error while following the constraints given in the feedback. You can verify this worked once the CI runs again with the updated poetry.lock file. 01:26:25 - openhands:INFO: resolve_issue.py:273 - I have updated the PR and resolved some of the issues that were cited in the pull request review. Specifically, I identified the following revision requests, and all the ones that I think I successfully resolved are checked off. All the unchecked ones I was not able to resolve, so manual intervention may be required:
This focused response directly addresses the CI error while following the constraints given in the feedback. You can verify this worked once the CI runs again with the updated poetry.lock file. |
@openhands-agent This PR's CI fails. Read the entire log of the failure: You need to know that this PR changes the dependency of openhands from browsergym to browsergym-core. Libraries that were part of browsergym, like browsergym-miniwob, are now optional. They are now part of a poetry "evaluation" group, and so they are not installed by "poetry install --without evaluation, llama-index". Read the log carefully. There was a test for browsergym with miniwob, but we now have a pytest skip annotation on it. Yet, the run still fails. Things to check:
Use your tools to navigate the codebase and understand how browsergym is used. Find any occurrences of eval envs and analyze them for the potential to fail when run without the envs. Then propose a fix for the issue. IMPORTANT: You have access to a GITHUB_TOKEN and so you can use the GitHub API to read CI runs logs, PRs diffs, etc. |
@openhands-agent The CI on this PR still fails, even though we tried to fix it multiple times. The failing test is test_browsergym_eval_env. Read it, and read all the file it is in. Lets make an experiment. Comment it out. Only this test, not the others in the same file. Make sure you do comment out its annotation too. That's it. You do not need to do anything more. I will run CI. |
@openhands-agent Python lint is failing. Here is the problem: tests/runtime/test_browsing.py. You know how to run lint on this project. Run it. Ruff will fix it, and you can commit its changes. |
@openhands-agent Python unit tests fail on this PR. The PR number is 5242. IMPORTANT: IMPORTANT: If you fail again doing that, then you can set up locally, but you must use: poetry install --without evaluation, llama-index |
@openhands-agent Python unit tests fail on this PR. The PR number is 5242. You can get the workflow runs logs to see the failing tests. IMPORTANT: IMPORTANT: If you fail again doing that, then you can set up locally, but you must use: |
This reverts commit c45cb45.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR proposes to use only
browsergym-core
for browsing, if we can. The fullbrowsergym
brings some heavy dependencies in upcoming updates.Testing:
Link of any specific issues this addresses
To run this PR locally, use the following command: