-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comments #395
Fix comments #395
Conversation
✅ Deploy Preview for delightful-daifuku-a9f6ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@haseebzaki-07 the main aim of the issue is to stop a user from deleting others' comments, which is not shown in the video. Also your seed data code is in this PR make sure to remove it |
@AlfiyaSiddique I will add the video from other people perspective and do the changes. |
hey @AlfiyaSiddique done the changes and video from others perspective 2024-10-30.21-30-14.mp4 |
@haseebzaki-07 some comments and make sure that the parameters are passed properly from frontend because getting this error in console: |
hey @AlfiyaSiddique I fixed the error logs and there are no problems form the frontend. |
🎉 Thank you @haseebzaki-07 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
What does this PR do?
This PR updates the comments schema, controller for creating and deleting comments also modifies the frontend API calls to match the purpose.
2024-10-30.16-15-09.mp4
Fixes #332
How should this be tested?
go to the recipe/:id page and try to delete the comments of other users.
Checklist
Required
console.logs