Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments #395

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Fix comments #395

merged 10 commits into from
Oct 31, 2024

Conversation

haseebzaki-07
Copy link
Contributor

What does this PR do?

This PR updates the comments schema, controller for creating and deleting comments also modifies the frontend API calls to match the purpose.

Screenshot 2024-10-30 152420
Screenshot 2024-10-30 152642

2024-10-30.16-15-09.mp4

Fixes #332

How should this be tested?

go to the recipe/:id page and try to delete the comments of other users.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing guide
  • Self-reviewed my own code
  • Checked for warnings, there are none
  • Removed all console.logs
  • The changes don't cause any responsiveness issues

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
🔨 Latest commit 1bc0779
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/67231a7299deb200081df1df
😎 Deploy Preview https://deploy-preview-395--delightful-daifuku-a9f6ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlfiyaSiddique
Copy link
Owner

@haseebzaki-07 the main aim of the issue is to stop a user from deleting others' comments, which is not shown in the video.
Either for users who are not allowed to delete comments do not show the button or on clicking the delete button raise toast saying you are not eligible for this action!

Also your seed data code is in this PR make sure to remove it

@haseebzaki-07
Copy link
Contributor Author

@AlfiyaSiddique I will add the video from other people perspective and do the changes.

@haseebzaki-07
Copy link
Contributor Author

haseebzaki-07 commented Oct 30, 2024

hey @AlfiyaSiddique done the changes and video from others perspective

2024-10-30.21-30-14.mp4

@AlfiyaSiddique
Copy link
Owner

@haseebzaki-07 some comments and make sure that the parameters are passed properly from frontend because getting this error in console:
image

@AlfiyaSiddique AlfiyaSiddique added gssoc-ext For GSSOC Extended Contribution. level 2 GSSOC level 2 Contribution - 25 points hacktoberfest-accepted labels Oct 30, 2024
@haseebzaki-07
Copy link
Contributor Author

haseebzaki-07 commented Oct 31, 2024

hey @AlfiyaSiddique I fixed the error logs and there are no problems form the frontend.
And please let me know if there are more issues to work on.

@AlfiyaSiddique AlfiyaSiddique merged commit 8af7e8f into AlfiyaSiddique:master Oct 31, 2024
5 checks passed
Copy link

🎉 Thank you @haseebzaki-07 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 2 GSSOC level 2 Contribution - 25 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Visitors should not be allowed to alter comments
2 participants