i have added footer #35
Conversation
✅ Deploy Preview for delightful-daifuku-a9f6ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @shivamy009 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
|
@shivamy009
|
AlfiyaSiddique
added
gssoc-ext
|
Adding some more improvement in the code fix that as well. |
| @@ -3,7 +3,7 @@ | |||
| } | |||
|
|
|||
| #root { | |||
| max-width: 1366px; | |||
| /* max-width: 1366px; */ | |||
There was a problem hiding this comment.
Do not left old code on comment out remove it Completely.
| @@ -45,7 +46,9 @@ function App() { | |||
| <Route path="/user/:id/update/recipe" element={<UpdateRecipe />} /> | |||
| <Route path="/recipe/:id" element={<OneRecipe/>} /> | |||
| </Routes> | |||
| <Footer /> | |||
| {/* <Footer /> */} | |||
| <Footer1 /> | |||
There was a problem hiding this comment.
Instead of making another footer file why don't you add the new footer code to the old file only?
Please do this. And Remove Footer1.jsx
Try to add your code to existing files only unless it does not need a new file for a component or page
|
ok i will fix all these problem |
|
@shivamy009 any updates ? |
|
Hey @AlfiyaSiddique If he is not working on this issue may be I can work in this. |
|
@harish08102004 go ahead , assigning this issue to you. |
|
@harish08102004 please comment below issue #15 so that I can assign it to you. |
|
@harish08102004 are you willing to work on #15 ? |
|
Hey i can work |
|
@harish08102004 then please make a comment on issue #15 , I need to assign this issue to you in order you to work on it. |
AlfiyaSiddique
removed
gssoc-ext
I have added this footer.
I have made another jsx file for footer.
I have added tailwind css also
problem no. -#15