Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification bell Added #27

Merged

Conversation

TanmayKalra09
Copy link
Contributor

@TanmayKalra09 TanmayKalra09 commented Oct 2, 2024

Issue: #20
I have added the notification bell beside the login/signup, and it redirects the page to http://localhost:5173/notifications
image

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
🔨 Latest commit 604c622
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/66fd573659ec270008a376b2
😎 Deploy Preview https://deploy-preview-27--delightful-daifuku-a9f6ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlfiyaSiddique
Copy link
Owner

Hey @TanmayKalra09
What about building the notification page aren't you going to do it?
Also notification bell should only appear if the user is logged in, Please fix it.

@TanmayKalra09
Copy link
Contributor Author

Hey @TanmayKalra09 What about building the notification page aren't you going to do it? Also notification bell should only appear if the user is logged in, Please fix it.

Hey @AlfiyaSiddique I have done the change that notification bell would only display if the user is logged in, can you please specify more about the notification page?

@AlfiyaSiddique
Copy link
Owner

The notification page should have all the notifications related to that user for example if someone likes the user's recipe or someone dislikes a recipe or if someone follows. These all notifications will be shown on the Notification page Just like Instagram.
@TanmayKalra09 Let me know if you can do this or not.

@TanmayKalra09
Copy link
Contributor Author

Sorry, @AlfiyaSiddique this would be a little difficult for me :(
I need some time for this issue, I have to do some research about this. At this point, I won't be able to do such modifications.

@AlfiyaSiddique
Copy link
Owner

Okay no worries @TanmayKalra09 , will be merging this PR by EOD with only the notification icon and page addition.
Thanks for your contribution:)

@AlfiyaSiddique AlfiyaSiddique added gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 1 GSSOC level 1 Contribution - 10 points labels Oct 3, 2024
@AlfiyaSiddique AlfiyaSiddique self-requested a review October 3, 2024 16:48
@AlfiyaSiddique AlfiyaSiddique merged commit bdf80fc into AlfiyaSiddique:master Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 1 GSSOC level 1 Contribution - 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants