Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] implementing delegate in contract, and submitting offer to handler from UI #28

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Jovonni
Copy link
Collaborator

@Jovonni Jovonni commented Aug 20, 2024

Early draft for implementing delegate

  • added convenience for CLIENTADDR to receive uosmo over IBC at fund stage of deployment
  • added test foundation, not fleshed out yet
  • added offer handler for fundAndDelegate, invitation maker, and interface guard
  • fetching delegations for wallet address in client
  • asset selection in UI populates with native denoms the wallet has a balance for
  • modal for funding amount before offer is submitted
  • passing validator through offer args with chain

fixing issue with IBC brand not being in agoricNames

Questions:

  1. Should we add a new brand to vbankassets/agoricNames? or can we simply structure the brand in the UI?
  2. will the transfers work if the denom being transferred is not in vbankassets? if so, we are good to go

Testing question

Should our tests aim to successfully verify funds are staked?

@Jovonni Jovonni self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant