Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert to the default Coloring for all other watchers #613

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

brayo-pip
Copy link
Member

@brayo-pip brayo-pip commented Oct 4, 2024

This reverts to the previous coloring pattern for all watchers except window, afk, web, editor and stopwatch.
image


Important

Reverts default coloring logic for non-specific event categories in getCategoryColorFromEvent() in color.ts.

  • Behavior:
    • Reverts default coloring logic for events in getCategoryColorFromEvent() in color.ts.
    • Uses getColorFromString(getTitleAttr(bucket, e)) for non-specific categories (not window, afk, web, editor, stopwatch).

This description was created by Ellipsis for 0a83764. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0a83764 in 8 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/util/color.ts:144
  • Draft comment:
    The change from getCategoryColorFromString(e.data.title) to getColorFromString(getTitleAttr(bucket, e)) alters the logic for determining the color for events not covered by specific conditions. Ensure that getTitleAttr returns a consistent and expected string for color mapping, as this could affect color consistency across the application.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_AhTYIcFCd3oK4zjL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@brayo-pip
Copy link
Member Author

brayo-pip commented Oct 4, 2024

Previously lastfm and the media watcher were greyed out. I forgot to take a screenshot before :(

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 25.98%. Comparing base (0cf7831) to head (0a83764).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/util/color.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   25.98%   25.98%           
=======================================
  Files          27       27           
  Lines        1643     1643           
  Branches      292      279   -13     
=======================================
  Hits          427      427           
- Misses       1157     1190   +33     
+ Partials       59       26   -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare
Copy link
Member

Very nice! Do you think it's good enough to make a release out of once merged? :)

@brayo-pip
Copy link
Member Author

Yeah we should probably make it a release.

@ErikBjare ErikBjare merged commit 85c007e into ActivityWatch:master Oct 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants