Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed packages from blacklist #106

Open
wants to merge 4 commits into
base: travis
Choose a base branch
from
Open

removed packages from blacklist #106

wants to merge 4 commits into from

Conversation

kunalsinx
Copy link

No description provided.

@kunalsinx kunalsinx changed the title removed packages removed packages from blacklist May 2, 2016
@abinashmeher999
Copy link
Member

@kunal-iitkgp

  1. You need to send a PR against the igcv_nav branch. The travis branch was temporary and I should have deleted it after the PR.
  2. Obviously the tests will fail. The names of packages were supposed to be removed one by one maintaining that the builds pass. Removing all at once will obviously show errors. Please see the link that I mentioned in the slack channel or the other PR where I mentioned about from where I followed it. That link will also tell you that rosdep is to be used to manage binary dependencies. Read more about rosdep.

@abinashmeher999
Copy link
Member

@satyeshmundra Please help him. You know what to do.

@kunalsinx
Copy link
Author

@abinashmeher999 I knew build was going to fail and I was unable to activate travis on my local repo so I choose to send this PR to travis branch.

@abinashmeher999
Copy link
Member

So were you able to activate it on your local repo?

@kunalsinx
Copy link
Author

yup .... so I just have to check for which packages the build fails and keep them in blacklist ?

@abinashmeher999
Copy link
Member

For now, yes. Do that first. Then the task will be to fix their builds and remove them from blacklist. It will be incremental.

@abinashmeher999
Copy link
Member

@kunal-iitkgp Use git rebase -i to clean up the history.

@kunalsinx
Copy link
Author

will squash them once done with the work

@abinashmeher999
Copy link
Member

Till now there are 0 changes right. You want to start afresh. Good to
remove all the commits.

Regards,

Abinash Meher

On Tue, May 3, 2016 at 3:26 PM, Kunal Singh [email protected]
wrote:

will squash them once done with the work


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#106 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants