convert cloud hosted custom module into a policy #1
Conversation
mikz
force-pushed
the
apicast-policy-chain
branch
from
412b091
to
000a6f0
Compare
mikz
force-pushed
the
apicast-policy-chain
branch
13 times, most recently
from
e5a60d9
to
ec2d2e4
Compare
mikz
force-pushed
the
apicast-policy-chain
branch
from
ec2d2e4
to
bcdf4bb
Compare
|
@3scale/operations we need to figure out how to use stock apicast image and add this customization with s2i to build new image on OpenShift. |
apicast/Makefile
Outdated
| @@ -1,6 +1,6 @@ | |||
| .DEFAULT_GOAL := help | |||
|
|
|||
| APICAST_VERSION ?= v3.0.0 | |||
| APICAST_VERSION ?= policy-chain | |||
There was a problem hiding this comment.
I don't see this version in quay.
There was a problem hiding this comment.
Ah forget about it, I see that you changed this in another commit.
| @@ -0,0 +1 @@ | |||
| requires 'Test::APIcast', '0.04'; | |||
There was a problem hiding this comment.
0.04 is an old version. Although the latest will be installed anyway unless we pin the version with ==.
There was a problem hiding this comment.
Yep. I think that is fine. This library is already installed in the apicast image so this just ensures it has the right version.
.circleci/config.yml
Outdated
| (cd apicast && make push REMOTE_IMAGE_NAME=apicast-cloud-hosted:apicast-${CIRCLE_TAG:-${CIRCLE_BRANCH}}) | ||
| (cd mapping-service && make push IMAGE_TAG=${CIRCLE_TAG:-${CIRCLE_BRANCH}}) | ||
| fi | ||
|
|
||
| apicast-test: | ||
| docker: | ||
| - image: quay.io/3scale/s2i-openresty-centos7:1.13.6.1-rover5 |
There was a problem hiding this comment.
Latest is s2i-openresty-centos7:1.13.6.1-rover6
apicast/t/blacklist.t
Outdated
| use warnings FATAL => 'all'; | ||
| use Test::APIcast::Blackbox 'no_plan'; | ||
|
|
||
| repeat_each(1); |
There was a problem hiding this comment.
I think this one can be run twice. Delete this line so Test::APIcast applies its default?
apicast/t/module.t
Outdated
| use warnings FATAL => 'all'; | ||
| use Test::APIcast::Blackbox 'no_plan'; | ||
|
|
||
| repeat_each(1); |
mikz
force-pushed
the
apicast-policy-chain
branch
from
9e8d170
to
5925384
Compare
This is an attempt to use 3scale/APIcast#450 in production use case.
TODO:
/usr/bin/container-entrypoint: line 16: /usr/libexec/s2i/run: No such file or directorywhen running built image without a command (fix running runtime image without a command s2i-openresty#42)