Delete old CORS module example #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example uses the old Apicast module system. Now we have a CORS policy that uses the new policy chain system.
|
It's not a big deal for me....but if this (and other) examples cannot be made to work with the api that's in the head of master, I would just delete them.... If people want them as examples to evolve/learn etc - they can do that with what's in the last release.... |
|
Also we could replace this by how to enable the CORS policy. Because right now there is not much documentation about that. But that should be tackled in #481 |
davidor
changed the title
mikz
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes the old CORS module example. Now we have a CORS policy (#487) that uses the new policy chain system, so this example is no longer relevant.