fix is_http2_request

3scale · Nov 3, 2023 · 9efa110 · 9efa110
1 parent 060982a
commit 9efa110
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/dev-environments/grpc/README.md b/dev-environments/grpc/README.md
@@ -33,7 +33,10 @@ docker compose -p grpc logs -f one.upstream
 ## Testing
 
 
-Get `grpcurl`
+
+Get `grpcurl`. You need [Go SDK](https://golang.org/doc/install) installed.
+
+Golang version >= 1.18 (from [fullstorydev/grpcurl](https://github.com/fullstorydev/grpcurl/blob/v1.8.9/go.mod#L3))
 
 ```sh
 make grpcurl

diff --git a/gateway/src/apicast/configuration/service.lua b/gateway/src/apicast/configuration/service.lua
@@ -34,7 +34,7 @@ local http_methods_with_body = {
 }
 
 local function is_http2_request()
-  return ngx.req.http_version == '2.0'
+  return ngx.req.http_version() == 2.0
 end
 
 local function content_type_is_urlencoded(headers)
@@ -56,7 +56,6 @@ end
 local function read_body_args(...)
   local method = ngx.req.get_method()
 
-  ngx.log(ngx.WARN, "is_http2_request: ", is_http2_request())
   if is_http2_request() then
     return {}, 'not supported'
   end
@@ -206,7 +205,6 @@ end
 local function get_request_params(method)
   local params = ngx.req.get_uri_args()
 
-  ngx.log(ngx.WARN, "is_http2_request: ", is_http2_request())
   if is_http2_request() then
     return params
   end