Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREESCALE-11281 - bump to go 1.22 #1036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

THREESCALE-11281 - bump to go 1.22 #1036

wants to merge 1 commit into from

Conversation

valerymo
Copy link
Contributor

@valerymo valerymo commented Nov 27, 2024 •
edited
Loading

Jira: https://issues.redhat.com/browse/THREESCALE-11281

Verification

  1. Install and sanity validation
    3scale installed locally
~/go/3scale-operator git branch --show-current
THREESCALE-11281-1


cd 3scale-operator
make install
export NAMESPACE=3scale-test
oc new-project $NAMESPACE
oc project $NAMESPACE
make download
make run

Installed correctly
routes/UI verified

~/go/3scale-operator oc project
Using project "3scale-test" on server "https://api.vmo01.xxxxx".
~/go/3scale-operator date                     
Wed Nov 27 19:17:24 EET 2024
~/go/3scale-operator git branch --show-current
THREESCALE-11281-1
~/go/3scale-operator oc get deploy            
NAME                 READY   UP-TO-DATE   AVAILABLE   AGE
apicast-production   1/1     1            1           36m
apicast-staging      1/1     1            1           36m
backend-cron         1/1     1            1           40m
backend-listener     1/1     1            1           40m
backend-redis        1/1     1            1           40m
backend-worker       1/1     1            1           40m
system-app           1/1     1            1           34m
system-memcache      1/1     1            1           40m
system-mysql         1/1     1            1           40m
system-redis         1/1     1            1           40m
system-searchd       1/1     1            1           40m
system-sidekiq       1/1     1            1           36m
zync                 1/1     1            1           36m
zync-database        1/1     1            1           36m
zync-que             1/1     1            1           36m
~/go/3scale-operator
  1. CVEs analysys
    Quay.io Security Scan - Passed
  • Image was built to see CVE check in Quay.io.
  • Repo: quay.io/vmogilev_rhmi/3scale-operator:test-go122
  • Command used to build image (on Mac arm):
docker build . --platform linux/amd64 -t quay.io/vmogilev_rhmi/3scale-operator:test-go122

image

image

@valerymo valerymo requested a review from a team as a code owner November 27, 2024 10:25
@valerymo valerymo force-pushed the THREESCALE-11281-1 branch 8 times, most recently from fd1d38c to 0260d86 Compare November 27, 2024 13:52
@valerymo valerymo changed the title [WIP]THREESCALE-11281 - bump to go 1.22 THREESCALE-11281 - bump to go 1.22 Nov 27, 2024
MStokluska
MStokluska reviewed Nov 28, 2024
View reviewed changes
PROJECT
- group: apps
-
# TODO(user): Uncomment the below line if this resource implements a controller, else delete it.
# controller: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be uncommented right?

MStokluska
MStokluska reviewed Nov 28, 2024
View reviewed changes
PROJECT
- group: apps
-
# TODO(user): Uncomment the below line if this resource implements a controller, else delete it.
# controller: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too? Can you review this file again please

MStokluska
MStokluska reviewed Nov 28, 2024
View reviewed changes
PROJECT
kind: APIManager
# TODO(user): Update the package path for your API if the below value is incorrect.
path: k8s.io/api/apps/v1alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MStokluska MStokluska MStokluska left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valerymo @MStokluska