Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(howitworks, navbar, sectiontwo, common): improve display, transla… #122

Merged
merged 5 commits into from
Nov 26, 2023
Merged

fix(howitworks, navbar, sectiontwo, common): improve display, transla… #122

merged 5 commits into from
Nov 26, 2023

Conversation

Khalil-NOUI
Copy link
Contributor

@Khalil-NOUI Khalil-NOUI commented Nov 25, 2023 •
edited by HachemBouhadede
Loading

improve display, translation

resolves #120

Related Issue

@Khalil-NOUI Khalil-NOUI added the bug Something isn't working label Nov 25, 2023
@Khalil-NOUI Khalil-NOUI added this to the v1.0 Release milestone Nov 25, 2023
@Khalil-NOUI Khalil-NOUI self-assigned this Nov 25, 2023
@Khalil-NOUI Khalil-NOUI linked an issue Nov 25, 2023 that may be closed by this pull request
fix HomePage Carousel and Navbar #120
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aidebeaide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2023 0:17am

@Khalil-NOUI
Copy link
Contributor Author

navbar dont show for smallscreen with controls in the bottom

@Khalil-NOUI
Copy link
Contributor Author

merge after meeting

@Khalil-NOUI
Copy link
Contributor Author

@HachemBouhadede @oualidelh @iman-om all good to merge

HachemBouhadede
HachemBouhadede approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@HachemBouhadede HachemBouhadede left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work khalilou,
nothing to comment on anything cz there's nothing i can that benifits the code, GGs , i didn't check the preview for internet reason (4g is slow atm), but good work <3

@Khalil-NOUI Khalil-NOUI merged commit 8bb651e into develop Nov 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HachemBouhadede HachemBouhadede HachemBouhadede approved these changes

Assignees

@Khalil-NOUI Khalil-NOUI

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0 Release
Development

Successfully merging this pull request may close these issues.

fix HomePage Carousel and Navbar
2 participants
@Khalil-NOUI @HachemBouhadede