93 enhance page header social share panel #103
Conversation
…ine-capstone into 93-enhance-page-header-social-share-panel
BREAKING CHANGE: display favicon and page title "resolves #93"
BREAKING CHANGE: e the breaking changes: "resolves #93"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| {error} | ||
| </p> | ||
| <> | ||
| <IndexPage title='Edit Profile' /> |
There was a problem hiding this comment.
shouldn't this be in the profile/[id]/editProfile ? it shouldn't be in componenets
| <HiChevronRight /> | ||
| </div> | ||
| <> | ||
| <IndexPage title={`${eventDisplay.title}`} /> |
There was a problem hiding this comment.
same headr, i supposed headers go to pages not componenets
There was a problem hiding this comment.
but i understand why you're using it her, anyway, as long as it works <3
| {t("editEvent.intro")} | ||
| </p> | ||
| <> | ||
| <IndexPage title={`Edit Event ${oldInfo.title}`} /> |
There was a problem hiding this comment.
i get the logic of writing as a component, i think it's actually brilliant, but with all these changes, i think the standard way could've easier, anyway, hope this gets solved out soon ! and great efforts khalil
| <div className='w-7 h-7 bg-gray-50 rounded-full text-red-500 flex justify-center items-center'> | ||
| <LuFilterX /> | ||
| <> | ||
| <IndexPage title='All Events' /> |
There was a problem hiding this comment.
Aide for Aide Events or Our Events ! could be nice :D
| {t("createEvent.intro")} | ||
| </p> | ||
| <> | ||
| <IndexPage title='Create an Event' /> |
There was a problem hiding this comment.
i kinda unerstand why you'd use the indexPage components in componenets that are meant for dynamic pages, but for static pages, i defently think it's prefarble to put them in pages
| /> | ||
| )} | ||
| <> | ||
| <IndexPage title={`${userData.displayName} events`} /> |
There was a problem hiding this comment.
yeah this seems more logical
src/pages/index.jsx
Outdated
| @@ -15,6 +16,7 @@ export default function HomePage({ props }) { | |||
|
|
|||
| return ( | |||
| <> | |||
| <IndexPage title='Pebble' /> | |||
There was a problem hiding this comment.
don't forget to update the title
There was a problem hiding this comment.
Aide be Aide :)
|
current error, |
|
@HachemBouhadede |
|
still same issue with vercel here's a suggution idea @Khalil-NOUI for this page make the header a normal one don't use the indexPage componenet just to solve it out |
…ine-capstone into 93-enhance-page-header-social-share-panel
…ge, improve tranlsation BREAKING CHANGE: head translation resolves #93
|
All good to GO !, |
-enable tab title meta Info and enable share feature in the single event page
-enhance translation in some lacking components