Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 category card #52

Merged
merged 5 commits into from
Oct 20, 2023
Merged

10 category card #52

merged 5 commits into from
Oct 20, 2023

Conversation

LaidBengli
Copy link
Collaborator

No description provided.

@darinetag darinetag added the Feature Request 🚀 New feature or request label Oct 20, 2023
@@ -0,0 +1,18 @@
import React from "react";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for cleaner code, remove the import from react

const CategoryCard = ({ category }) => {
return (
<div className='max-w-sm mx-auto bg-white rounded-xl shadow-md overflow-hidden'>
<img
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done

@darinetag
Copy link
Collaborator

@ismail-benlaredj can you check the prettier issue then close the PR.

Copy link
Collaborator

@SaraBegache SaraBegache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please apply what @darinetag suggested, thank you.

@ismail-benlaredj ismail-benlaredj merged commit 2f1a043 into dev Oct 20, 2023
3 checks passed
@ismail-benlaredj ismail-benlaredj deleted the 10-category-card branch October 20, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants