Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90 add second theme #92

Merged
merged 3 commits into from
Nov 17, 2023
Merged

90 add second theme #92

merged 3 commits into from
Nov 17, 2023

Conversation

riadhmouamnia
Copy link
Collaborator

@riadhmouamnia riadhmouamnia commented Nov 17, 2023

Theme Implementation and UX Enhancement

fixes #90

Description:
I've successfully implemented the specified tasks for the second theme, scroll-to-top button, and smooth scrolling between sections. Here's a brief overview of the accomplished tasks:

  1. Second Theme Implementation:

    • Introduced a new theme option for the website.
    • Created a toggle button to enable users to switch between the two themes seamlessly.
    • Ensured the new theme maintained a consistent color scheme, adjusting any existing colors and CSS for a harmonious appearance.
  2. Scroll to Top Button:

    • Implemented a functional button that smoothly scrolls the page to the top upon clicking.
    • Ensured the button was accessible and functional across all pages.
  3. Smooth Scrolling Between Sections:

    • Added smooth scrolling functionality when navigating between different sections on the website.
    • Note: Animation for section transitions is intentionally deferred, pending the landing page sections' design implementation by other teammates.

I kindly ask my fellow teammates to review this Pull Request and provide valuable feedback. Additionally, I'm aware that animations are pending for the landing page sections, and I appreciate any contributions in that regard. Your insights and approval are crucial for merging these enhancements into the main project. Thank you for your collaboration! 🚀🌐💻

Related Issue

@riadhmouamnia riadhmouamnia linked an issue Nov 17, 2023 that may be closed by this pull request
7 tasks
Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
team-a ✅ Ready (Inspect) Visit Preview Nov 17, 2023 2:07pm

Copy link
Collaborator

@liliumorion liliumorion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, amazing job @riadhmouamnia , I loved the second theme. I felt very comfortable using our website in night mode, thank you for your diligence, you may now merge your PR.

@riadhmouamnia riadhmouamnia merged commit d380e0c into develop Nov 17, 2023
6 checks passed
@riadhmouamnia riadhmouamnia deleted the 90-add-second-theme branch November 17, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sprint six
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add second theme
4 participants