Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

85 create newsletter section #86

Merged
merged 8 commits into from
Nov 11, 2023
Merged

Conversation

liliumorion
Copy link
Collaborator

@liliumorion liliumorion commented Nov 11, 2023

Related Issue

add initial newsletter structure

fix #85
add validation and state managment to newsletter using formik and yup

fix #85
Update handleBlur to trigger onBlur only when the subscribe button is clicked, and not when the
input is touched.

fix #85
Integrate external newsletter service for newsletter subscription

fix #85
test styling in newsletter section

fix #85
add subscription success page

fix #85
add newsletter test files

fix #85
@liliumorion liliumorion added enhancement New feature or request sprint five labels Nov 11, 2023
@liliumorion liliumorion added this to the Ui Enhancement milestone Nov 11, 2023
@liliumorion liliumorion self-assigned this Nov 11, 2023
@liliumorion liliumorion linked an issue Nov 11, 2023 that may be closed by this pull request
5 tasks
Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
team-a ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2023 4:58pm

Copy link
Collaborator

@riadhmouamnia riadhmouamnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval Review: "Newsletter Section"

Reviewer: @riadhmouamnia

Feedback:
The implementation of the newsletter section is commendable, demonstrating a well-thought-out layout, pleasing color scheme, and effective imagery. The overall design is neat, and the functionality meets expectations.

Approved Changes:
The suggested enhancement for the mobile view, making the subscribe button full width, aligns with the goal of improving user interaction. The proposed adjustment is accepted and is expected to enhance the overall mobile user experience.

image

Additional Notes:

  • Thumbs up for the attention to detail and the effort in refining the section.
  • Request to thoroughly test and validate the mobile design to guarantee a seamless user experience.

Great work on the newsletter section! The acceptance of the suggested enhancement reflects a commitment to continuous improvement and user-centric design. Keep up the good work! 👍🏽🚀

@riadhmouamnia

@riadhmouamnia
Copy link
Collaborator

Also one additional note:

Could you consider using a slightly lighter font for the title and experiment with adding some letter spacing? Applying the tracking-wider or tracking-widest class can be a good starting point.

@liliumorion
Copy link
Collaborator Author

i'm on it @riadhmouamnia

resize subscribe button in mobile view, and update title spacing

fix #85
@liliumorion liliumorion merged commit 258708b into develop Nov 11, 2023
5 checks passed
@liliumorion liliumorion deleted the 85-create-newsletter-section branch November 11, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sprint five
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Newsletter Section
3 participants