-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
85 create newsletter section #86
Conversation
add initial newsletter structure fix #85
add validation and state managment to newsletter using formik and yup fix #85
Update handleBlur to trigger onBlur only when the subscribe button is clicked, and not when the input is touched. fix #85
Integrate external newsletter service for newsletter subscription fix #85
test styling in newsletter section fix #85
add subscription success page fix #85
add newsletter test files fix #85
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval Review: "Newsletter Section"
Reviewer: @riadhmouamnia
Feedback:
The implementation of the newsletter section is commendable, demonstrating a well-thought-out layout, pleasing color scheme, and effective imagery. The overall design is neat, and the functionality meets expectations.
Approved Changes:
The suggested enhancement for the mobile view, making the subscribe button full width, aligns with the goal of improving user interaction. The proposed adjustment is accepted and is expected to enhance the overall mobile user experience.
Additional Notes:
- Thumbs up for the attention to detail and the effort in refining the section.
- Request to thoroughly test and validate the mobile design to guarantee a seamless user experience.
Great work on the newsletter section! The acceptance of the suggested enhancement reflects a commitment to continuous improvement and user-centric design. Keep up the good work! 👍🏽🚀
Also one additional note: Could you consider using a slightly lighter font for the title and experiment with adding some letter spacing? Applying the tracking-wider or tracking-widest class can be a good starting point. |
i'm on it @riadhmouamnia |
resize subscribe button in mobile view, and update title spacing fix #85
Related Issue