Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item details page): fix card height #114

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

riadhmouamnia
Copy link
Collaborator

@riadhmouamnia riadhmouamnia commented Nov 24, 2023

Fix item details card height

Description::
This pull request resolves the issue of inconsistent height in the item details card, ensuring a visually harmonious presentation. Along the way, I've also tackled a missing translation in the dashboard for the "no items found" text, providing a more complete and localized experience. Additionally, I've improved the loading UI on the items page Carousel by adjusting colors for a more consistent and polished look. I would greatly appreciate your feedback on these changes.

fixes #113

*Screenshots:
image

Related Issue

fix card details height

fixes #113
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
team-a ✅ Ready (Inspect) Visit Preview Nov 24, 2023 8:15pm

Copy link
Collaborator

@liliumorion liliumorion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cards now have a fixed height, good job! 🚀

Copy link
Collaborator

@farouk26 farouk26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the card on multiple devices and it looks amazing , thank you for the fast hotfix , you may now merge the PR

@liliumorion liliumorion merged commit 7e6aede into develop Nov 24, 2023
6 checks passed
@liliumorion liliumorion deleted the 113-fix-item-details-card-height branch November 24, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants