generated from 202306-NEA-DZ-FEW/movie-project
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
Open
github-classroom
wants to merge
80
commits into
feedback
Choose a base branch
from
master
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd configurations #2
feat(setup gitflow): adds GitFlow to the project & adds a feature bra…
add a card component using Material UI #5
feat(api-utility): create API utility for Organized API Requests
refactor(component): add a card component
add moviescredits component to the actor page
feat(component): add moviescredits component
add Tv credits to the actors page(this shows other tv shows of the same actor) "fix #6"
feat(component): add Tv credits to the actors page
feat(component): add searchbar feature which returns an array of sear…
feat(footer): names and Links
Navbar contain logo genres and movies list and search box #8
feat(create navbar): create Navbar
…der with smooth transitions Closes #19
feat(create a homepage slider): implemented a responsive homepage sli…
…nent Created a small slider component that displays cards with content. This slider is designed to showcase and navigate through multiple card components Closes #21
feat(slider & cards): implement card slider component and cards compo…
feat(homepage): create the project's homepage
add poster and container to the single movie page Closes #28
add actor-avatar component and a rating component Closes #30
feat(movieid): add a server side fetch function
…list feat: add functionality to genres drops down list
style(singlemovie): styling For Single Movie Page
feat: adding single actor page
feat(navbar): add Navigation Function to Navbar
Feature/single actor page
…rtvshow feat(singleactor): add Single-Page Actor and TV Show Slider
fix(gitproblem): git problem
style(navbar searchbar result): style the navbar searchbar results
…slider and actors add a link to the cards on the home page and to the actors in the movie id page Closes #59
feat(footer): create a footer and add styling to it
feat(smallcards slider actoravatar): add a link to the cards and the …
style(readme): create Readme File
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
master
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
master
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @Zino0031 @iman-om @Ben-Tewfik @melissasidisid @ikoworld