generated from 202306-NEA-DZ-FEW/movie-project
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
Open
github-classroom
wants to merge
85
commits into
feedback
Choose a base branch
from
master
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… link to single movie page This change involves the creation of a new home page that features a dynamic card slider displaying trending movies. Users can interact with these cards to navigate to the respective single movie pages for more details. BREAKING CHANGE: create home page fix #8
In this update, I have introduced the actor card component and implemented the actors page. The actor card component will be used to display detailed information about actors, while the actors page will serve as a hub to explore and learn more about various actors within the project. BREAKING CHANGE: created actor page
…t-11 New actor page component 11
8 create home page
This change involves the addition of a footer component to the project. The footer will serve as a consistent and informative element across all pages, providing essential links and information to enhance the overall user experience. BREAKING CHANGE: created footer fix #7
feat(footer): add footer to the project
9 movies page
in this changes we added paginations in the movies and actors pages fix #41
feat(pagination): add pagination to movies and actors page
…ages feat(chore): add loaders
in this changes we fixed responsiveness in Home page and Footer fix #14
…sign style(project): fix responsivness
…links feat(functional logo): make the logo functional & leads to the homepage
style(project core): add general styling and applied it to all the pr…
in this changes we added the tv shows page and added it to the navbar fix #40
feat(tv shows): add tv shows, fix some issues
…website style(overall project): in this issue, metadata was handled
Merge to Master
✅ Deploy Preview for 10melon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
master
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
master
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @0m3ga13 @liliumorion @Zohir-kk @LaidBengli @SaraBegache