Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event styling responsiveness #186

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Fix event styling responsiveness #186

merged 5 commits into from
Nov 28, 2023

Conversation

Ben-Tewfik
Copy link
Contributor

@Ben-Tewfik Ben-Tewfik commented Nov 28, 2023 •
edited
Loading

Description

In this pr, i made the following changes:

  • Adjusted the width and height of the event card and tested responsiveness across multiple screen sizes.
  • Add my picture to about us

Screenshots

image

Related Issue

@Ben-Tewfik Ben-Tewfik linked an issue Nov 28, 2023 that may be closed by this pull request
Fix event styling responsiveness #182
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
student-store ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 11:56am

@Ben-Tewfik Ben-Tewfik self-assigned this Nov 28, 2023
@Ben-Tewfik Ben-Tewfik added bug Something isn't working design Styling is involved labels Nov 28, 2023
hocine1212
hocine1212 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@hocine1212 hocine1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done tewfik

khaoulasara
khaoulasara approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@khaoulasara khaoulasara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enhances the styling of the page. Approved. Good to merge.

@khaoulasara khaoulasara merged commit ca5cb15 into develop Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaoulasara khaoulasara khaoulasara approved these changes

@hocine1212 hocine1212 hocine1212 approved these changes

@samiba6 samiba6 Awaiting requested review from samiba6

@KatiaGhezali KatiaGhezali Awaiting requested review from KatiaGhezali

@MouniaBelkheir MouniaBelkheir Awaiting requested review from MouniaBelkheir

Assignees

@Ben-Tewfik Ben-Tewfik

Labels
bug Something isn't working design Styling is involved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix event styling responsiveness
3 participants
@Ben-Tewfik @hocine1212 @khaoulasara