Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if unexpected HTTP status code is returned #8

Open
physikerwelt opened this issue Sep 3, 2021 · 2 comments
Open

Throw an error if unexpected HTTP status code is returned #8

physikerwelt opened this issue Sep 3, 2021 · 2 comments

Comments

@physikerwelt
Copy link
Member

requests.post(post_url, headers=headers)

Currently the response is not used at all.

@dehsani-academic
Copy link
Collaborator

If there are thousands of entries, but only one error, I wouldn't want an error thrown. The API will return error codes one can use to check the success or failure of entries. Maybe a success/failure report could be created instead.

@physikerwelt
Copy link
Member Author

I agree. However the method should throw an error which should be caught in the for loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants