Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Around fix #157

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Around fix #157

wants to merge 3 commits into from

Conversation

xinminglai
Copy link

Hi, Please merge this branch,
This branch makes the around modifier behave correctly for multiple overrides within multiple components.
Thanks!

This way, the around with <: super :> will work for base template with
role.
It doesn't pass the test t/030_kolon/012_cascade.t because of losing
original code. This fix the bug.
@syohex
Copy link
Contributor

syohex commented Jan 24, 2016

Is this related to #156 ? And tests are failed except 5.8.

@xinminglai
Copy link
Author

Not for issue #156.
Please ignore this branch for now, The around fix needs more work.
We need the c3 algorithm to make the around work as expected.
This patch only fixes the simple case in around modifier for template.
Where the declaration in single inheritance.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants