Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QrCode Type type as string #122

Open
AmbrosioV opened this issue Nov 29, 2021 · 6 comments
Open

QrCode Type type as string #122

AmbrosioV opened this issue Nov 29, 2021 · 6 comments

Comments

@AmbrosioV
Copy link

Hey, In CreateCode function the Type parameter should be string?
I'm having issues with TS on that part as the string value of QrCode.Type.Dynamic does not overlaps with the QrCodeTypes object

@xen-HendryZheng
Copy link
Contributor

Hi @AmbrosioV can you attached the error you're encountering from your IDE? We don't see any linting error on both TS and JS.

@AmbrosioV
Copy link
Author

AmbrosioV commented Dec 6, 2021

Hey thx for your fast response, here's an img
image

@fachryadhitya
Copy link

fachryadhitya commented Mar 10, 2022

Hey thx for your fast response, here's an img image

You actually had to type Qrcode.type.Dynamic (Or Static) to get the correct type. Perhaps I could open a PR so that the type is autocompleted nicely? @xen-HendryZheng

here is the PR Link if you wanted to change, ty 🙌🏻

@muasx88
Copy link

muasx88 commented May 23, 2023

hi, i got the same issue on createCode (QrCode).
about the PR, when it be merge? we need it.

@adityarx
Copy link

@fachryadhitya @muasx88, the PR contains changes to package-lock.json which is outside of the scope of this issue. If we can revert it (or alternatively @muasx88 if you could raise a new PR with just the type change) we're happy to review and release a new version

@muasx88
Copy link

muasx88 commented May 24, 2023

i've created a new issue: #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants