Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/injectable request params #120

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature/injectable request params #120

wants to merge 5 commits into from

Commits on Oct 13, 2017

  1. Added request attribute annotation. Can be used together with data-sl… 

    …y-use=${'com.cognifide.slice.TestModel' @ myAttribute='aValue'} to read out the attribute
    @royteeuwen
    royteeuwen committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    7e98ba4 View commit details
    Browse the repository at this point in the history

  2. Fix the request processor by using the servlet request (which is alwa… 

    …ys available, in contrast of sling servlet request)
    @royteeuwen
    royteeuwen committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    ce9748e View commit details
    Browse the repository at this point in the history

  3. Make request nullable because in the unit/integration tests it might … 

    …not be available
    @royteeuwen
    royteeuwen committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    d9b165d View commit details
    Browse the repository at this point in the history

  4. Made it possible to inject request parameters in a model and to adapt… 

    … from a request immediatly instead of using request.getResource(). This way you could adapt your request in a servlet to a model with request parameters as fields.
    @royteeuwen
    royteeuwen committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    b3eb3e5 View commit details
    Browse the repository at this point in the history

  5. Use servlet request for parameters as to make sure its always available

    @royteeuwen
    royteeuwen committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    cab9f7a View commit details
    Browse the repository at this point in the history