Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images missing on Wikisource #23

Open
Daniel-Mietchen opened this issue Jul 28, 2014 · 5 comments
Open

Images missing on Wikisource #23

Daniel-Mietchen opened this issue Jul 28, 2014 · 5 comments
Assignees

Comments

@Daniel-Mietchen Daniel-Mietchen changed the title Images missing Images missing on Wikisource Jul 28, 2014
@Klortho
Copy link
Member

Klortho commented Jul 31, 2014

The XSLT doesn't handle at all right now. This might be a bit of work...

@Klortho
Copy link
Member

Klortho commented Jul 31, 2014

It might not be so bad. The has a ref-type of fig. So I think the XSLT should do this:

  • If it encounters such an , and there is no preceding with the same rid attribute value, then apply-templates on the that is referenced by that rid.

Then it won't matter that the fig actually appears in the float-group at the end.

@Klortho
Copy link
Member

Klortho commented Jul 31, 2014

I think I might have fixed it, but I can't tell when I upload to my test wiki, because it doesn't have the figures. Daniel, if you could send me a text about how to push XSLT changes to the bot, or if you have some other way of testing, please do.

Here are some notes to myself:

Trouble article:

export XML_CATALOG_FILES=`pwd`/dtd/catalog-test-jats-v1.xml
xsltproc jats-to-mediawiki.xsl \
    'Biodivers_Data_J_2014_Jul_8_(2)_e1161/biodiversity_data_journal-2-e1161.nxml' \
    > PMC4092324.mw.xml

Compare with article that does have good figures:

export XML_CATALOG_FILES=~/jats/jatspacks/catalog.xml
xsltproc jats-to-mediawiki.xsl \
    'PLoS_Genet_2006_Dec_22_2(12)_e220/pgen.0020220.nxml' \
    > PMC1713255.mw.xml

@Daniel-Mietchen
Copy link
Member Author

I can't push to the bot (pinging @notconfusing ) but you can have the figures on your test wiki via https://www.mediawiki.org/wiki/InstantCommons .

@wrought
Copy link
Member

wrought commented Sep 17, 2014

Issue is resolved for figures but not tables as on 10.3897/BDJ.2.e1161 see #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants