Fix network tables #815
Merged
Fix network tables #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was relying on the main plugin's subscribe-all behavior
Prevents data type issues where topic ordering is nondeterministic and type information could arrive after sources are set up
Was based on NT table structures, which weren't returning correct data
Shuffleboard historically relied on the assumption that a leading slash was optional for paths in networktables. NT4 changed that by making topic names exact (so two topic names only differing by the presence or absence of a leading slash would be two unique topics), which broke NT data sources for topics without leading slashes
Open
rzblue
approved these changes
Nov 1, 2024
PeterJohnson
reviewed
Nov 1, 2024
| @@ -102,12 +102,12 @@ public void start() { | |||
| }); | |||
|
|
|||
| metadataSubscriber = | |||
| new MultiSubscriber(inst, new String[] {METADATA_TABLE_NAME + "/"}, PubSubOption.hidden(true)); | |||
| new MultiSubscriber(inst, new String[] {METADATA_TABLE_NAME + "/"}, PubSubOption.sendAll(true)); | |||
There was a problem hiding this comment.
What’s the reason for the sendAll()?
There was a problem hiding this comment.
Ah, good catch, this was copied at one point from the NetworkTableSource code. The metadata table is read-only from the dashboard side so this isn't needed
We don't write to the metadata topics, it's all sent over from the server
PeterJohnson
approved these changes
Nov 2, 2024
|
On WPILib 2025-Beta-1 Note that the robot program is running in Simulate Robot Code mode and the data in the NT looks correct. Everything is running on Windows 11. Does this fix the lack of special |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes several bugs related to networktables:
.typebased widget #814)