Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: refactor S3 to use an object oriented pattern #26

Open
MoralCode opened this issue Nov 7, 2024 · 1 comment
Open

Proposal: refactor S3 to use an object oriented pattern #26

MoralCode opened this issue Nov 7, 2024 · 1 comment

Comments

@MoralCode
Copy link
Contributor

it seems like all the calls to s3 are passing a global object into them

Seems like it may be better to create an S3 class to handle all the s3 operations (which would set up nicely for #17 )

I have already made this change on a local branch that depends on several other branches so i know it works (oh and i migrated S3 over to boto3 and it works as far as i can tell)

@MoralCode
Copy link
Contributor Author

My PR for this currently depends on #29. i could probably refactor it to avoid this if need be, but if #29 is gonna get merged id rather not waste the effort.

also i developed this while trying to do the boto -> boto3 migration. I could maybe separate it into two PR's if you'd rather tackle it in stages, but again, wanted to check before going through the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant