-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta issue] Fix external references to HTML user activation behavior #5129
Comments
FYI for other spec owners: we will need to rewrite the dependency on user activation using the new classification as a guide. Here is a quick rule of thumb, but each spec still needs a careful look for corner cases: most other specs we checked refer to the old model using something like "allow the API when triggered by user activation/user gesture"; we will need to replace the phrase with "allow the API when (a specific) Please reach out to us (@domenic or me) for API specific guidance. |
User activation in Permissions API: w3c/permissions#194 |
Vibration API: WICG/interventions#47 |
WebBluetooth: WebBluetoothCG/web-bluetooth#463 |
WebUSB: WICG/webusb#178 |
Clipboard API: w3c/clipboard-apis#107 |
Payment Request API: w3c/payment-request#883 |
Payment Request and Wake Lock API also need guidance 🙏 (sorry for lack of links, on phone). Once I understand a bit more I’ll also be able to help with the updates. |
Fullscreen: whatwg/fullscreen#160 (Edited the issue reference, the old one was about changing a current fullscreen behavior.) |
This comment has been minimized.
This comment has been minimized.
Just notes as I'm working on updating specs:
That would allow other specs to say in the Privacy/Sec sections, "The X API is a [=Transient activation-gated API=]." Moar thinking out loud, what would have been cool is a WebIDL extended attribute: interface PaymentRequest {
[Activation="transient"] Promise show();
}; then the WebIDL can find the Window, do the check, and throw the SecurityError DOMException. |
I think "expired" need to be exported also, no? I feel like I want to write:
Also, the spec text seems to imply that "transient activation" is always bound to a Window? (i.e., |
Guidance that should also be provided is the best way to pull the window from the |
Ok, so, might be good to add a note that Editor's don't need to check for "expired"... I definitely think we should provide guidance on getting the Window object from inside a method. I reached for:
But I'm unsure if that's "best practice"™️. |
Web NFC: w3c/web-nfc#449 |
Web Audio API: WebAudio/web-audio-api#2107 |
This is intentionaly vague to not restrict implementors: it's plausible that an implementation chooses to be transient or sticky here. This fixes WebAudio#2107. Address comments from Marcos Don't use explicit link, and follow the guideline in https://github.com/whatwg/html/issues/5129\#issuecomment-562210730
This is intentionaly vague to not restrict implementors: it's plausible that an implementation chooses to be transient or sticky here. This fixes #2107. Address comments from Marcos Don't use explicit link, and follow the guideline in https://github.com/whatwg/html/issues/5129\#issuecomment-562210730
Minor editorial updates to fix a few broken links and correct references: - Drop custom definitions that are no longer needed - Replace "triggered by user activation" with new user activation model (see whatwg/html#5129) - Use back ticks for values instead of var shorthand - Drop link to feature name in Feature Policy (term no longer exists)
A few editorial updates to fix a few broken links and references: - Drop custom dfns that are no longer needed (fixes a few outdated fragments and allows to see which additional dfns the spec needs on top of those that the referenced specs export) - Replace "triggered by user activation" with new user activation model (see whatwg/html#5129). This may warrant another iteration as I'm not clear whether we're supposed to call the "activation notification" steps - Update definition of methods to fix IDL links - Update reference to Web App Manifest and flag the paragraph as informative - Fix links to "action"
We have collected a set of general tips in this doc: User Activation: Guidance for spec authors. We will try our best to keep the doc updated if we encounter anything that applies to more than a few specs. |
A few editorial updates to fix a few broken links and references: - Drop custom dfns that are no longer needed (fixes a few outdated fragments and allows to see which additional dfns the spec needs on top of those that the referenced specs export) - Replace "triggered by user activation" with new user activation model (see whatwg/html#5129). This may warrant another iteration as I'm not clear whether we're supposed to call the "activation notification" steps - Update definition of methods to fix IDL links - Update reference to Web App Manifest and flag the paragraph as informative - Fix links to "action"
Adapt to whatwg/html#5129 and follow the spec editing advice from https://docs.google.com/document/d/14wT89JZ0qeRehXGkcn3_meXxjvlHKgM9d7aJj80kQcQ/edit ("User Activation: Guidance for spec authors") by replacing "triggered by user activation" with "the current global object has transient activation". This makes ReSpec happy again.
Adapt to whatwg/html#5129 and follow the spec editing advice from https://docs.google.com/document/d/14wT89JZ0qeRehXGkcn3_meXxjvlHKgM9d7aJj80kQcQ/edit ("User Activation: Guidance for spec authors") by replacing "triggered by user activation" with "the current global object has transient activation". This makes ReSpec happy again.
The Wake Lock spec is being updated in w3c/screen-wake-lock#252 |
Adapt to whatwg/html#5129 and follow the spec editing advice from https://docs.google.com/document/d/14wT89JZ0qeRehXGkcn3_meXxjvlHKgM9d7aJj80kQcQ/edit ("User Activation: Guidance for spec authors") by replacing "triggered by user activation" with "the current global object has transient activation". This makes ReSpec happy again.
Adapt to whatwg/html#5129 and follow the spec editing advice from https://docs.google.com/document/d/14wT89JZ0qeRehXGkcn3_meXxjvlHKgM9d7aJj80kQcQ/edit ("User Activation: Guidance for spec authors") by replacing "triggered by user activation" with "the current global object has transient activation". This makes ReSpec happy again.
We have just landed the revamped user activation model in the HTML spec, closing #1903 and #3859. It's time to fix other specs that refer to the old activation model. (Note that the PR above fixes the references within the HTML spec.)
We will track the overall progress of the work (in other specs) through this meta-issue. Each of those other specs will still need its own tracking issue; this meta-issue will simply link to the external issues.
[Last update: 2021-Apr-15] Here is a task list for external APIs mentioned in this thread below. We will try to keep the list updated (manually) to ease progress tracking:
The text was updated successfully, but these errors were encountered: