From c94701e2365adbd5be9ff622e4ec066ef847cd3e Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 18 Oct 2022 13:23:26 -0700 Subject: [PATCH 01/15] Hide pop-ups when making an element fullscreen This is part of the new pop-up attribute: https://github.com/whatwg/html/pull/8221 --- fullscreen.bs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fullscreen.bs b/fullscreen.bs index 877f192..4357720 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -65,8 +65,15 @@ stated otherwise it is unset.

All documents have an associated list of pending fullscreen events, which is an ordered set of (string, element) tuples. It is initially empty. -

To fullscreen an element, set element's fullscreen flag -and add it to its node document's top layer. +

To fullscreen an element: + +

    +

  1. Run {hide all pop-ups until} given null, false, and true. + +

  2. Set element's fullscreen flag + +

  3. add it to its node document's top layer. +

To unfullscreen an element, unset element's fullscreen flag and iframe fullscreen flag (if any), and remove it from From 404bf0dc252abd041db2a8d1135eccc9e8b030e0 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Fri, 11 Nov 2022 09:08:09 -0800 Subject: [PATCH 02/15] Don't allow fullscreen on showing popovers --- fullscreen.bs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fullscreen.bs b/fullscreen.bs index 4357720..781af6f 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -241,6 +241,8 @@ if all of the following are true, and false otherwise:

  • element's node document is allowed to use the "fullscreen" feature. + +

  • element is not in the {{popover showing state}}.

    From 8c7ef0c4255f4436f141ec230db787a9d295139a Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Thu, 17 Nov 2022 17:01:22 -0800 Subject: [PATCH 03/15] https://chromium-review.googlesource.com/c/chromium/src/+/4032790 --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 781af6f..e925b53 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -68,7 +68,7 @@ is an ordered set of (string, element) tuples. It is

    To fullscreen an element:

      -

    1. Run {hide all pop-ups until} given null, false, and true. +

    2. Run {hide all pop-ups until} given null, false, and false.

    3. Set element's fullscreen flag From 15648d030034c3889e72b0666814b16e7db8447f Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 14 Feb 2023 10:53:17 -0800 Subject: [PATCH 04/15] Fix popover showing state reference Co-authored-by: Anne van Kesteren --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index e925b53..279fc5c 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -242,7 +242,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

    4. element is not in the {{popover showing state}}. +

    5. element is not in the [=popover showing state=].

      From cf5bc17c13899e9fa8456fe3c9ba952ca8473413 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 14 Feb 2023 10:53:52 -0800 Subject: [PATCH 05/15] Replace pronouns Co-authored-by: Anne van Kesteren --- fullscreen.bs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fullscreen.bs b/fullscreen.bs index 279fc5c..ea37848 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -70,9 +70,10 @@ is an ordered set of (string, element) tuples. It is

      1. Run {hide all pop-ups until} given null, false, and false. -

      2. Set element's fullscreen flag +

      3. Set element's fullscreen flag. -

      4. add it to its node document's top layer. +

      5. Add element to element's node document's + top layer.

      To unfullscreen an element, unset element's From 73a1ae14ddcecbffc336c1012a3c5381a8c2c2f9 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Sat, 25 Mar 2023 11:22:38 -0700 Subject: [PATCH 06/15] change hide all popups until to hide all popovers --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index ea37848..7ea6df5 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -68,7 +68,7 @@ is an ordered set of (string, element) tuples. It is

      To fullscreen an element:

        -

      1. Run {hide all pop-ups until} given null, false, and false. +

      2. Run {hide all popovers}.

      3. Set element's fullscreen flag. From dbaef786865706397c6a53e94c0fc399dc2cd0a2 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Sat, 25 Mar 2023 11:25:59 -0700 Subject: [PATCH 07/15] fix popover showing state reference --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 8f8296b..7ddced9 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

      4. element is not in the [=popover showing state=]. +

      5. element is not in the {popover showing state}.

        From 25c9af084bb360629d4e1f5bd1e0bef08e5bc005 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 6 Apr 2023 16:01:08 +0200 Subject: [PATCH 08/15] Update fullscreen.bs --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 7ddced9..9132e79 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -64,7 +64,7 @@ is an ordered set of (string, element) tuples. It is

        To fullscreen an element:

          -

        1. Run {hide all popovers}. +

        2. Run hide all popovers.

        3. Set element's fullscreen flag. From a59d9f2ba2f31f20b9782d4ac929b7c3cc324b51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 6 Apr 2023 16:03:13 +0200 Subject: [PATCH 09/15] Update fullscreen.bs --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 9132e79..b1a9883 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -64,7 +64,7 @@ is an ordered set of (string, element) tuples. It is

          To fullscreen an element:

            -

          1. Run hide all popovers. +

          2. Run hide all popovers given element's node document.

          3. Set element's fullscreen flag. From e5eb313d02802239eb381ce22d5430aa0dc19e3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 6 Apr 2023 16:05:14 +0200 Subject: [PATCH 10/15] Update fullscreen.bs --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index b1a9883..aded1ed 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

          4. element is not in the {popover showing state}. +

          5. element is not in the popover showing state.

            From a01f3149ea5d9a70182ef1ae35eef1b12309b412 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 6 Apr 2023 16:14:48 +0200 Subject: [PATCH 11/15] Update fullscreen.bs --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index aded1ed..4d43b71 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

          6. element is not in the popover showing state. +

          7. element is not in the popover showing state.

            From b7103672420d99b8fe71a6edeb39cc2c4458971f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 6 Apr 2023 16:17:08 +0200 Subject: [PATCH 12/15] Update fullscreen.bs --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 4d43b71..05fdc2e 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

          8. element is not in the popover showing state. +

          9. element's popover visibility state is not showing.

            From ad47d02a5b6d36fb08fc5cc5343cc97feda65f5c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Thu, 6 Apr 2023 16:19:21 +0200 Subject: [PATCH 13/15] Update fullscreen.bs --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 05fdc2e..7df3592 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

          10. element's popover visibility state is not showing. +

          11. element's popover visibility state is hidden.

            From a1b9c10b27570909088eac2f5c6683acfb540f0d Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Mon, 10 Apr 2023 12:34:45 -0400 Subject: [PATCH 14/15] add HTML element check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Philip Jägenstedt --- fullscreen.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index 7df3592..c879633 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,7 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

          12. element's popover visibility state is hidden. +

          13. element namespace is not the HTML namespace or element's popover visibility state is hidden.

            From 4d375fe98312da6e5b353043939a755330c36268 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Mon, 1 May 2023 07:55:54 -0700 Subject: [PATCH 15/15] wrap long line --- fullscreen.bs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fullscreen.bs b/fullscreen.bs index c879633..d326868 100644 --- a/fullscreen.bs +++ b/fullscreen.bs @@ -239,7 +239,9 @@ if all of the following are true, and false otherwise: data-lt="fullscreen-feature">fullscreen" feature. -

          14. element namespace is not the HTML namespace or element's popover visibility state is hidden. +

          15. element namespace is not the HTML namespace or + element's popover visibility state is hidden.