Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify behavior of popovers with fullscreen API #216

Closed
nt1m opened this issue Feb 14, 2023 · 3 comments
Closed

Specify behavior of popovers with fullscreen API #216

nt1m opened this issue Feb 14, 2023 · 3 comments

Comments

@nt1m
Copy link
Member

nt1m commented Feb 14, 2023

Currently showModal() cannot be called on dialogs that are popovers to avoid conflicting elements in the top layer.

In a similar fashion, you shouldn't be able to request fullscreen on popovers. I assume this was an oversight since the fullscreen spec is separate.
@annevk
Copy link
Member

annevk commented Feb 14, 2023

cc @josepharhar @mfreed7

@josepharhar
Copy link
Contributor

This PR prevents popovers which are showing from getting fullscreen: #204

@nt1m
Copy link
Member Author

nt1m commented Jul 23, 2023

Fixed by #204

@nt1m nt1m closed this as completed Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @nt1m @josepharhar