Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch_embed related questions. #85

Open
zijunwei opened this issue Dec 14, 2021 · 1 comment
Open

patch_embed related questions. #85

zijunwei opened this issue Dec 14, 2021 · 1 comment

Comments

@zijunwei
Copy link

Hi, Thanks for providing the code! I have a couple of questions regarding patch_embedding.

  1. in https://github.com/whai362/PVT/blob/v2/segmentation/pvt.py#L148, the last layer you added one more embed feature than the num_patches but it seems this extra feature has no where to be used. You explicitly removed it in https://github.com/whai362/PVT/blob/v2/segmentation/pvt.py#L202. Is this design for some specific purpose? (backward compatibility?)
  2. https://github.com/whai362/PVT/blob/v2/segmentation/pvt.py#L183 why specifically compare with patch_embed1? Is this not supposed to compare to each patch_embed?
@Roger-Liang
Copy link

@zijunwei
I have the same confusion about your questions. Did you solve them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants