-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error and warning zigzag lines overlap the text #248
Comments
thats odd. The theme itself doesnt control the size or placement of any of that. Are you sure you dont have a weird line-height setting? What happens if you change the font? Maybe something odd that the italics are causing? |
I've been using the theme for years already and just got this odd thing. VScode Info: |
it is the same even with different fonts. I also reset the line-height as I was using suggested recommendations here |
This issue is also reported after the recent VS Code version: Code 1.88.0 update: Please consider giving this VS Code issue a like and leaving a comment there, so that it could be given higher priority for the upcoming release. Temporary SolutionUse less vibrant color or any other color you may like for the underline: "workbench.colorCustomizations": {
"[Cobalt2]": {
"editorError.foreground": "#ff000088",
"editorWarning.foreground": "#ffe60033",
"editorInfo.foreground": "#00ff0088"
}
} Or, disable the zigzag lines and use a background color instead:"workbench.colorCustomizations": {
"[Cobalt2]": {
"editorError.foreground": "#00000000",
"editorError.background": "#ff003333",
"editorError.border": "#00000000",
"editorWarning.foreground": "#00000000",
"editorWarning.background": "#ffff0022",
"editorWarning.border": "#00000000",
"editorInfo.foreground": "#00000000",
"editorInfo.background": "#22EE0022",
"editorInfo.border": "#00000000"
}
} OptionalUse |
Night owl also reporting double underlines showing up.. Related? sdras/night-owl-vscode-theme#322 |
small update: MS is aware of the bug and someone is assigned: microsoft/vscode#209614 |
this has been fixed but wont hit a reease for a few more weeks. A fix for now:
document.body.insertAdjacentHTML('beforeend', `<style>.monaco-editor .view-overlays > div > div, .monaco-editor .margin-view-overlays > div > div { bottom: initial; }</style>`); You'll have to redo this for each instance of VS Code you open. |
@wesbos Hey, I wanted to use the opportunity to thank you for the great theme, I've been using it for years. Thanks for documenting the problem here. Let's hope a fix arrives sonn! |
Type: Bug
In any javascript project, enable eslint extension so it highlights errors and warning. The warnings and errors show zigzag yellow and red lines below the text. These lines are overlapped with text and makes text and warnings difficult to read.
Extension version: 2.4.3
VS Code version: Code 1.88.0 (Universal) (5c3e652f63e798a5ac2f31ffd0d863669328dc4c, 2024-04-03T13:28:18.899Z)
OS version: Darwin x64 23.2.0
Modes:
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
For more information, added the screenshots below with the default VS code theme and this theme.
I have been using this extension for almost 4 years and have never encountered any issues and this issue just after recent VS code update.
The text was updated successfully, but these errors were encountered: