Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Highlight Improvement for Python #233

Open
rennsax opened this issue Jul 26, 2023 · 1 comment
Open

Semantic Highlight Improvement for Python #233

rennsax opened this issue Jul 26, 2023 · 1 comment

Comments

@rennsax
Copy link
Contributor

rennsax commented Jul 26, 2023

As I've mentioned in #223 (comment), PR #223 seems to remove highlight of the conventional parameter self in Python.

Hello @SmitAkbari26 , I find this merge make `self` parameter lose its highlight when semantic tokens are enabled. Maybe more scopes should be considered.

Before:
image

After:
image

Python language server: Provided by the extension Pylance

I'm afraid that it's probably unreasonable. To compared with, we can see how the theme One Dark Pro handles this situation.

image

self is distinct from other variables, both in the color and style, therefore developers quickly distinguish them.

In fact, the problem is that cobalt2 theme doesn't support Python semantic highlight very much. I think this feature is necessary for Python devs including myself. Thanks for your consideration.

SmitAkbari26 added a commit to SmitAkbari26/cobalt2-vscode that referenced this issue Aug 20, 2023
@SmitAkbari26
Copy link
Contributor

Apologies for the delayed response, as I haven't been actively checking GitHub lately. I solve this self parameter lose its highlight when semantic tokens are enabled.

image

@Eitheages I hope i solve problem what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants