-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-photo-album and change code to support v3 #11303
Conversation
Size Change: -1.56 kB (-0.16%) Total Size: 969 kB
ℹ️ View Unchanged
|
Tests seem to fail because the provided stylesheet can't be loaded properly.
|
I'm not sure I'm a fan of the stylesheet, especially as it seems to load on every page. Tempted to stay on v2 of the package, or maybe download the stylesheet and re-add it as styles of our own? |
Ticket created to explore other avenues. In the meantime, we'll stick to v2 as discussed. |
What does this change?
As per #11294
Moving to v3 broke a few things https://github.com/igordanchenko/react-photo-album/releases/tag/v3.0.0 so I aimed to figure out how to not change anything UI facing whilst going with what is now offered by the library.
How to test
How can we measure success?
Up to date packages and seemingly lighter version of it.
Have we considered potential risks?
If well tested, low risk