-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does the exit fullscreen actually consume user activation? #36481
Comments
I'm thinking we might need to add something to Web Driver to consume user activation. Otherwise, we are going to be relying on APIs like Payment Request to consume it, which is not great. |
There's discussion about this in whatwg/fullscreen#152 that's unresolved. It does seem like Chrome has this, but there are special cases for Pointer Lock and perhaps other APIs? |
Adding a WebDriver API for consumption is a great suggestion, thanks! Otherwise, testing consumption is a big challenge. All browsers consume user activation at |
Yeah, let's work on standardizing that. I filed:
Yeah, that will also break when testing on mobile too. That's probably not going to work.
Alternative is to use Payment Request, which is standardized and interoperable (so long at the various payment methods are supported across UAs, would need to check 🤞). It might look like: const pr =new PaymentRequest(methods, details, options);
await test_driver.bless("Payment Request");
pr.show(); // consumes transient activation...
await pr.abort(); // hides the payment sheet. |
Closing based on progress we made on whatwg/fullscreen#152 |
@mustaqahmed, in the user activation tests, there is the following util function that varies tests rely on:
wpt/html/user-activation/resources/utils.js
Lines 25 to 33 in 3768c85
However, in the fullscreen spec, I don't see where it says "consume user activation"?
My understanding is that fullscreen doesn't consume user activation, it just requires it.
cc @annevk
The text was updated successfully, but these errors were encountered: