Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strategy for managing lightpush and filter clients with status sharding #1203

Open
chaitanyaprem opened this issue Aug 22, 2024 · 0 comments

Comments

@chaitanyaprem
Copy link
Collaborator

Problem

As of now filter and lightpush clients are limited either via rate-limiting or number of filter subscriptions/peers in a global config.
But considering status sharding approach of having 2 common shards (32 and 64) and upto 100 community specific shards a different strategy in allowing particular number of clients per protocol per shard is needed.

Suggested solution

one simple strategy is to have a total number of clients to be supported as a config and just divide by number of shards local node is supporting. e.g: if total filter clients to be allowed is 1000 and node supports 100 shards then 10 clients per shard. But this may not be valid in case of application like status since common shards would be used by all app instances whereas community specific shards will be used by a small subset of overall nodes.
which means we will have to take some sort of shard level configuration as input or have 2 default configs (1 for common shards and 1 for community shards).

Approach TBD

cc @waku-org/nwaku-developers

Alternatives considered

TBD

Acceptance criteria

have tests or simulations to verify the strategy works with many shards.

@chair28980 chair28980 added this to Waku Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant