Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-position-4] redundant document argument for top layer manipulation algorithms #8849

Closed
foolip opened this issue May 17, 2023 · 1 comment

Comments

@foolip
Copy link
Member

foolip commented May 17, 2023

https://drafts.csswg.org/css-position-4/#top-manip

This sections contains algorithms like "add an element to the top layer, given a Document doc and an Element el". The call sites for these in whatwg/fullscreen#223 and whatwg/html#9093 always pass in the element's node document as the first argument. In HTML there is a document variable handy so the invocation looks OK, but in Fullscreen we'll have invocations like this:

Request removal from the top layer given element's node document and element

By having only element as the argument, the call sites will be simpler, and there's no question about whether the document can be some other document.

cc @josepharhar @mfreed7 @tabatkins @nt1m @annevk

@josepharhar
Copy link
Contributor

josepharhar commented May 17, 2023

I am ok with removing the document parameter. Anne pointed this out in the HTML PR here: whatwg/html#9093 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants