Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will epd_push_pixels_lcd in s3 support partial area? #320

Closed
lanistor opened this issue Jun 8, 2024 · 9 comments · Fixed by #364
Closed

Will epd_push_pixels_lcd in s3 support partial area? #320

lanistor opened this issue Jun 8, 2024 · 9 comments · Fixed by #364
Labels
v7 version 7 of the hardware S3

Comments

@lanistor
Copy link

lanistor commented Jun 8, 2024

epd_push_pixels will always paint full screen on s3 board, for the macro RENDER_METHOD_LCD.
What should i to do for partial area clear?

@vroland
Copy link
Owner

vroland commented Jun 21, 2024

Ah indeed. Probably it would need pre-population of a masked line buffer for the affected lines, and then orchestrate the callbacks appropriately.

@vroland vroland added the v7 version 7 of the hardware S3 label Jun 21, 2024
@lanistor
Copy link
Author

Ah indeed. Probably it would need pre-population of a masked line buffer for the affected lines, and then orchestrate the callbacks appropriately.

It this need to modify the hardware circuit board? or only modify the software code?

@vroland
Copy link
Owner

vroland commented Aug 5, 2024

Only software modifications. Shouldn't be too crazy.

@lanistor
Copy link
Author

lanistor commented Aug 6, 2024

Waiting for your update👍.

Only software modifications. Shouldn't be too crazy.

@lanistor
Copy link
Author

@vroland Is this problem in plan?

@lanistor
Copy link
Author

lanistor commented Oct 14, 2024

@vroland Is there anything i can do to support it? May you guide me to do it?

@vroland
Copy link
Owner

vroland commented Oct 15, 2024

@lanistor hey, can you test if #364 fixes it for you? I finally found some time to just do it, it's not a lot of work at the end of the day.

@lanistor
Copy link
Author

@lanistor hey, can you test if #364 fixes it for you? I finally found some time to just do it, it's not a lot of work at the end of the day.

OK, i will test it soon, thanks a lot👍👍👍

@lanistor
Copy link
Author

@vroland I has tested it (#364), it can works perfect! Thanks a lot. 👍👍👍

vroland added a commit that referenced this issue Nov 3, 2024
Makes `epd_push_pixels` respect the given area on ESP32-S3 chips. This should fix #320 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v7 version 7 of the hardware S3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants