Update dependencies to address CVEs #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the dependency with the command: go get github.com/btcsuite/btcd/btcutil Relevant package updated: go: upgraded github.com/btcsuite/btcd v0.23.0 => v0.23.5-0.20231215221805-96c9fd8078fd
Updated the dependency with the command: go get go get github.com/moby/buildkit Relevant package updated: go: upgraded github.com/moby/buildkit v0.10.4 => v0.15.1
Found the corresponding dependency: go mod graph | grep github.com/nats-io/nats-server/v2 > github.com/go-kit/[email protected] github.com/nats-io/nats-server/[email protected] Updated the dependency with the command: go get github.com/go-kit/kit The dependency updated after updating: go mod graph | grep github.com/nats-io/nats-server/v2 > github.com/go-kit/[email protected] github.com/nats-io/nats-server/[email protected]
Change was performed in line 100 of go.mod file in commit 960870c Checking updated dependency: go mod graph | grep github.com/emicklei/go-restful > github.com/containerd/[email protected] github.com/emicklei/go-restful/[email protected]
AlexsandroRyan
force-pushed
the
pkg-updates-checkmarx-cves
branch
from
dc2a309
to
87ce1de
Compare
…2024-23653 We've update the github.com/moby/buildkit to newer version in the commit 960870c, but then verified there's one dependency using old buildkit version(this means that CVE-2024-23653 wasn't addressed): go mod graph | grep github.com/moby/buildkit > github.com/bufbuild/[email protected] github.com/moby/[email protected] Updated github.com/bufbuild/buf version to latest and newer version doesn't use buildkit anymore.
…22-24450 Update of the github.com/go-kit/kit to v0.13.0 in commit f5787ef addressed the CVE-2022-24450 Check: go mod graph | grep github.com/nats-io/nats-server/v2 > github.com/go-kit/[email protected] github.com/nats-io/nats-server/[email protected]
Updated the dependency with the command: go get github.com/adlio/schema Check: go mod graph | grep github.com/docker/docker > github.com/tendermint/tendermint github.com/docker/[email protected]+incompatible > github.com/adlio/[email protected] github.com/docker/[email protected]+incompatible > github.com/bufbuild/[email protected] github.com/docker/[email protected]+incompatible > github.com/bufbuild/[email protected] github.com/docker/[email protected] > github.com/moby/[email protected] github.com/docker/[email protected]+incompatible > github.com/moby/[email protected] github.com/docker/[email protected]
Change was performed in line 218 of go.mod file in commit a20047a Checking updated dependency: go mod graph | grep github.com/opencontainers/runc > github.com/adlio/[email protected] github.com/opencontainers/[email protected]
Change was performed in line 218 of go.mod file in commit a20047a Checking updated dependency: go mod graph | grep github.com/opencontainers/runc > github.com/adlio/[email protected] github.com/opencontainers/[email protected]
Change was performed in line 218 of go.mod file in commit a20047a Checking updated dependency: go mod graph | grep github.com/opencontainers/runc > github.com/adlio/[email protected] github.com/opencontainers/[email protected]
JpOnline
changed the title
JpOnline
changed the title
…23651 Run command: go get github.com/btcsuite/btcd/[email protected] Output: go: upgraded github.com/btcsuite/btcd v0.23.5-0.20231215221805-96c9fd8078fd => v0.24.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to address all the CVEs that were reported by Checkmarx tool when executed over this repository.
Previous conversation happened here cometbft#3558
I have so far updated all needed dependencies to fix the CVEs, but there are still some remaining and maybe someone else can help me to get it fixed.
go mod graph | grep google.golang.org/protobuf, we see a lot of packages using the version that contains the vulnerability, not sure if it's viable to update one by one.Let us know if this is suficient or if there's a better path for solving any of these quickly.
PR checklist
Tests written/updatedChangelog entry added in.changelog(we use unclog to manage our changelog)Updated relevant documentation (docs/orspec/) and code comments