Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

(impact:high) Lint rule to prevent public methods on WidgetObjects from returning WidgetObjectElement #335

Open
juanmendes opened this issue Apr 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@juanmendes
Copy link
Contributor

Prerequisites

  • [x ] Are you running the latest version?
  • [x ] Did you perform a basic issue search?

For more information, see the CONTRIBUTING guide.

Description

A widget object should not return WidgetObjectElements from public methods, they are only meant to be used internally within the widget object. Users of widget objects should always access methods of T which is the platform specific object, an Angular Element or Cypress Chainable . This can be enforced through linting.

Impact

Developers have been creating methods that return WidgetObjectElement and then calling unwrap() from multiple places.

@juanmendes juanmendes added the enhancement New feature or request label Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant