Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

(impact: medium) Improved Documentation for grid pagination key #300

Open
2 tasks done
juanmendes opened this issue Jan 22, 2021 · 0 comments
Open
2 tasks done

(impact: medium) Improved Documentation for grid pagination key #300

juanmendes opened this issue Jan 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@juanmendes
Copy link
Contributor

Prerequisites

[Check these off before submitting an issue].

  • Are you running the latest version?
  • Did you perform a basic issue search?

For more information, see the CONTRIBUTING guide.

Description

Posting on behalf of @mslavov and a few others

It would be great if the example includes how to provide the paginationTranslationKey as the format needs to be specific like {firstItem} - {lastItem} of {totalItems}

Alternatively, there could also be a way to pass the full translation yourself... that requires more work on callers since they have to retrieve the current page, total page count, total count.

Impact

Figuring out the format took me some code digging, this should be clearly specified in its API

@juanmendes juanmendes added the enhancement New feature or request label Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant