Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Expose builder creation flag for custom static hostnames #92

Open
dhiltgen opened this issue May 3, 2021 · 0 comments
Open

Expose builder creation flag for custom static hostnames #92

dhiltgen opened this issue May 3, 2021 · 0 comments

Comments

@dhiltgen
Copy link
Contributor

dhiltgen commented May 3, 2021

Describe the problem/challenge you have

In some environments DNS "challenges" can make it difficult to get all the required hostnames mapped through to the builder. Being able to inject custom static hostnames may be beneficial for some users.

As a short-term workaround, using kubectl patch ... can re-configure an existing builder. For example:

custom-hosts.yaml

spec:
  template:
    spec:
      hostAliases:
      - ip: 10.16.10.15
        hostnames:
        - "registry.acme.com"
        - "corpnas.acme.com"
% kubectl patch deployment buildkit --type merge --patch "$(cat custom-hosts.yaml )"
% kubectl delete replicaset -l app=buildkit

Description of the solution you'd like

Add new flag to kubectl buildkit create to pass one or more custom hostnames.

We'll need to explain the relationship between --add-host passed to builds vs. this new flag and reconcile any potential inconsistencies.

Design/Architecture Details
Wire up the custom hostAliases for the manifest generation based on this new flag.

Environment Details:

  • kubectl buildkit version (use kubectl buildkit version)
    0.1.3

  • Kubernetes version (use kubectl version)
    N/A

  • Where are you running kubernetes (e.g., bare metal, vSphere Tanzu, Cloud Provider xKS, etc.)

N/A

  • Container Runtime and version (e.g. containerd sudo ctr version or dockerd docker version on one of your kubernetes worker nodes)

N/A

Vote on this request

This is an invitation to the community to vote on issues. Use the "smiley face" up to the right of this comment to vote.

  • 👍 "This project will be more useful if this feature were added"
  • 👎 "This feature will not enhance the project in a meaningful way"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant