Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rsmd-guidelines #4014

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ivanmrsulja
Copy link
Member

@ivanmrsulja ivanmrsulja commented Oct 1, 2024

Corresponding Vitro PR.

What does this pull request do?

Added endpoints for software CRUD operations following Codemeta guidelines.

What's new?

  • edu.cornell.mannlib.vitro.webapp.controller.api.software.SoftwareController
  • edu.cornell.mannlib.vitro.webapp.controller.api.dto.AuthorDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.dto.FunderRequestDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.dto.FunderResponseDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.dto.SoftwareRequestDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.dto.SoftwareResponseDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.dto.InformationContentEntityResponseDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.utility.InformationContentEntityResponseDTO
  • edu.cornell.mannlib.vitro.webapp.controller.api.utility.InsertQueryBuilder

How should this be tested?

You first have to pull the corresponding Vitro PR. You can test this functionality using any client mocking tool such as Postman or cURL.

Additional Notes:

You can contact me if you want me to send you a Postman collection for testing.

Interested parties

@chenejac

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Java
  2. SPARQL
  3. Ontologies

@chenejac chenejac linked an issue Oct 1, 2024 that may be closed by this pull request
…ertQueryBuilder. Fixed deletion bug as well as some minor bugs.
resp.setStatus(500);
PrintWriter w = resp.getWriter();
w.println(message);
e.printStackTrace(w);

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

[Error information](1) can be exposed to an external user.
softwareDTO.internalIdentifier = softwareUri;
try {
resp.setContentType("application/json");
resp.getWriter().println(IndividualApiNetworkUtility.serializeToJSON(softwareDTO));

Check warning

Code scanning / CodeQL

Cross-site scripting

Cross-site scripting vulnerability due to a [user-provided value](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-like REST API endpoint for Software individuals
1 participant