Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

The equals and toString translations are open regardless of their parent classes #26

Open
vinivendra opened this issue Apr 29, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@vinivendra
Copy link
Owner

The translations for == and description are done manually and always include the open modifier. This is a problem when the enveloping class is marked as final, which causes Kotlin to raise a warning (since these methods can't be overridden anyway).

It would be better to set the isOpen property instead of adding the open keyword manually so it could be treated correctly. In this case, it's important to check if the transpilation pass that handles open/final comes after the one that translates == and description.

@vinivendra vinivendra added the enhancement New feature or request label Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant