Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even better markdown handling #100

Open
2 of 4 tasks
MahdiBM opened this issue Aug 18, 2023 · 2 comments
Open
2 of 4 tasks

Even better markdown handling #100

MahdiBM opened this issue Aug 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@MahdiBM
Copy link
Collaborator

MahdiBM commented Aug 18, 2023

Penny makes a lot of effort to show GitHub markdown strings in Discord, in a form that is nicer to see in Discord.
But I still want to make it even better:

  • Penny should convert strings like #66 to "Replace the "projectboard" workflow currently present in all repos #66" which is also a link, when sending to Discord.
  • Also should count the actual string value of only Text elements when doing String.unicodesPrefix() for markdown documents.
  • Turn "TODO lists" (like this list here in this issue) into normal bullet-point list, because Discord doesn't render these lists properly.
  • "trailingTextMinLength" should only take effect if the text doesn't fit in the maxVisualLength limit at all.
@MahdiBM MahdiBM added the enhancement New feature or request label Aug 18, 2023
@gwynne
Copy link
Member

gwynne commented Aug 18, 2023

You're just lucky SwiftMarkdown is built directly atop cmark-gfm (which is literally GitHub's Markdown flavor). That being said, I don't think the automagic conversion of issue/PR numbers to links etc. thing is all that important; they're very context-dependent and don't always work even on GitHub in places you might think they should. Also no one on Discord generally cares.

@MahdiBM
Copy link
Collaborator Author

MahdiBM commented Aug 18, 2023

I care though 🫣

I know not many people care, but if I were to work on penny with that assumption, I should've stopped a long time ago 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants