Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Door Configuration #107

Open
lazypower opened this issue Dec 8, 2020 · 3 comments
Open

Door Configuration #107

lazypower opened this issue Dec 8, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lazypower
Copy link
Contributor

Rendering the door/lock configuration is currently going to be a little painful if we ever change our door configurations on the VEM150 line. This isn't likely to spring up un-announced, however I did want to flag that we'd like to use a shorter-form to specify the configuration, and render a door configuration based on a simple map.

@lazypower lazypower added enhancement New feature or request help wanted Extra attention is needed labels Dec 8, 2020
@edaniszewski
Copy link
Contributor

would we want a similar issue opened for the i2c plugin (which exposes the lock devices) so we could also use that shorter-form to render lock configs?

@lazypower
Copy link
Contributor Author

The i2c chart has the template generation pattern, I'm not sure if we want to move it further down the dependency tree into the app, or a sidecar script, but yeah, feels like there's opportunity for these tasks to be linked and a uniform generator/template pattern emerge.

@edaniszewski
Copy link
Contributor

I think realistically moving it down somewhere would be nice, since the readability/maintainability of that template generation is uhh.. tribal knowledge and a headache at best.

I don't fully know if it could be pushed down to the plugin level, but it certainly could be put into some init/sidecar script. Possibly adding in support for some config template rendering stuff into the SDK would be a good idea, since if we are using it for one plugin, its entirely possible it would be useful for others, so getting generalized baked-in capabilities for that feels useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants