Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in ws client for streamed readings #38

Open
edaniszewski opened this issue Jan 13, 2021 · 0 comments
Open

bug in ws client for streamed readings #38

edaniszewski opened this issue Jan 13, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@edaniszewski
Copy link
Contributor

the data that is marshalled into a Reading is incorrect, as done via the websocket streamed readings. instead of initializing with the reading data, it initializes with the whole websocket payload which includes the metadata frame which wraps the reading.

this is a pretty straightforward fix. instead of passing in the entire websocket response, just pass in the synse data embedded within the ws response

@edaniszewski edaniszewski added bug Something isn't working good first issue Good for newcomers labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant