RFC: remove sycl chapter #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The topic was discussed in the WG. I talked 1-1 with Greg and Alexey and tried to incorporate their feedback. If no one objects within a week I will consider this proposal accepted and merge the PRs. |
timmiesmith
reviewed
Apr 14, 2024
proposals/001-removing-sycl.rst
Outdated
| Recommendation | ||
| Oneapi spec components should not use vendor extensions in interfaces. Either | ||
| wrap the type (example above) or work with SYCL WG to make it part of SYCL | ||
| spec or as a KHR extension. If there is a compelling reason to use a vendor |
There was a problem hiding this comment.
KHR is undefined at this point. I see it's defined as the identifier for supra-vendor organization extensions in https://registry.khronos.org/EGL/specs/eglspec.1.5.pdf. Will most readers be familiar with it through background with Khronos, or is a brief definition needed?
There was a problem hiding this comment.
I updated the explanation. @gmlueck: this was based on our conversation so please review
gmlueck
reviewed
Apr 15, 2024
gmlueck
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akukanov
@gmlueck
See uxlfoundation/oneAPI-spec#530