Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reference for threads. #593

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

hvdijk
Copy link
Collaborator

@hvdijk hvdijk commented Nov 20, 2024

Overview

Add missing reference for threads.

Reason for change

After the bump to OpenCL ICD Loader, on Ubuntu 20, linking FuzzCL fails with an undefined reference to pthread_create. It appears that the older version of OpenCL ICD Loader implicitly referenced libpthread, whereas the newer version does not.

Description of change

Explicitly add the reference instead.

Anything else we should know?

If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-19 on all modified code.

After the bump to OpenCL ICD Loader, on Ubuntu 20, linking FuzzCL fails
with an undefined reference to pthread_create. It appears that the older
version of OpenCL ICD Loader implicitly referenced libpthread, whereas
the newer version does not. Explicitly add the reference instead.
@hvdijk hvdijk merged commit eb34bd1 into uxlfoundation:main Nov 20, 2024
14 checks passed
@hvdijk hvdijk deleted the pthread branch November 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants