[oneMKL][Stats][Spec] Simplify and clean up Summary Statistics domain #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aelizaro
commented
Sep 4, 2023
aelizaro
commented
- Simplify examples and make them pseudocode
- Remove unnecessary details about dataset
|
@paveldyakov, @andreyfe1, @iMartyan please, take a look |
andreyfe1
approved these changes
Sep 4, 2023
|
|
||
| sycl::usm_allocator<float, sycl::usm::alloc::shared> allocator(queue); | ||
| // allocate USM memory for the dataset of the size n_observations * n_dims and fill it with any data | ||
| // allocate USM memory for the mean output of the size n_dims |
There was a problem hiding this comment.
USM is unified shared memory. So, USM memory stands for using "memory" twice :)
|
lgtm |
andreyfe1
approved these changes
Sep 5, 2023
paveldyakov
approved these changes
Sep 5, 2023
aepanchi
pushed a commit
to aepanchi/oneAPI-spec
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.